Reflected light phase curves #192
Conversation
Added a 'transfer' and 'shift' to atmosphere_4d and clouds_4d to fix phase curves for reflected cases. Various other lines, related to lab scattering approximations, have been commented out for now. Jit is now back on for fluxes.py > get_reflected_3d
Most recent version. Adjustments made to justdoit.py make micro adjustments in reflected light phase curves.
Added ng, nt =6 calculations. Added PICASO Branch print statement in atm_4d
deleted lots of stuff that is now in picaso_lab
|
@colinhamill would it be possible to resubmit this PR into the |
| @@ -1348,6 +1352,9 @@ def get_reflected_1d(nlevel, wno,nwno, numg,numt, dtau, tau, w0, cosb,gcos2, fta | |||
| 0.75*(1+cos_theta**2.0) #rayleigh phase function | |||
| ) | |||
| ) | |||
| elif single_phase==4:#'LAB': | |||
There was a problem hiding this comment.
@colinhamill am I okay to comment this out?
There was a problem hiding this comment.
or does it add some functionality ?
There was a problem hiding this comment.
Yes, this can be commented out or removed. This part is used for the Lab vs. DDA vs. HG study, and I forgot to remove it. It does not impact the reflected phase curve functionality.
| @@ -2671,12 +2673,12 @@ def atmosphere_4d(self, ds=None, shift=None, plot=True, iz_plot=0,verbose=True, | |||
| if isinstance(shift, type(None)): | |||
| shift = np.zeros(len(phases)) | |||
|
|
|||
| if zero_point == 'night_transit': | |||
| if zero_point == 'night_transit': ## does not work for reflected case! | |||
There was a problem hiding this comment.
So that is why there is now the "reorder" option in the plotting. Do you recommend I just take this out?
There was a problem hiding this comment.
Yes I think it'd be best to remove this since reorder_output will work for both the reflected and thermal case. If someone were to use zero_point='night_transit' for the reflected case, they would get bad output from atmosphere_4d and clouds_4d and it wouldn't be immediately clear that the output is wrong.
| shifted_grids = {} | ||
|
|
||
| # Add if calculation = reflected here: |
There was a problem hiding this comment.
The clouds_4d has this if statement for reflected and thermal. Does atmosphere_4d need it as well?
There was a problem hiding this comment.
Atmosphere_4d didn't end up needing an if statement here. The conditional statements in Line 2928 - 2930 (and Lines 2951 - 2953) make it so that the thermal phase curve functionality is not affected, but the parts of the reflected case that are not at full phase are shifted as needed.
Merges reflected light phase curve code for PR #192 in prep for Hamill et al. 2024
I added changes to allow calculation of reflected light phase curves. Most notable changes are confined to atmosphere_4d and clouds_4d in justdoit.py. I also assumed symmetry across phase = 0 deg (secondary eclipse) in fluxes.py > get_reflected_3d in order to calculate reflected phase intensity from 0-360 degrees.